Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_backend: Add optional derivation metadata when importing UFVKs with spending purpose. #1636

Merged
merged 2 commits into from
Dec 6, 2024
Merged

zcash_client_backend: Add optional derivation metadata when importing UFVKs with spending purpose. #1636

merged 2 commits into from
Dec 6, 2024

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Dec 5, 2024

No description provided.

@nuttycom nuttycom force-pushed the wallet/imported_spending_key_metadata branch 2 times, most recently from 8955be6 to 7fa87b5 Compare December 5, 2024 23:07
str4d
str4d previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7fa87b5 with a small concern.

zcash_client_sqlite/src/wallet.rs Show resolved Hide resolved
zcash_client_sqlite/src/wallet/db.rs Show resolved Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/add_account_uuids.rs Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.89655% with 25 lines in your changes missing coverage. Please review.

Project coverage is 56.37%. Comparing base (c33ad67) to head (cc2dfbf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
zcash_client_backend/src/data_api.rs 27.77% 13 Missing ⚠️
zcash_client_sqlite/src/wallet.rs 68.00% 8 Missing ⚠️
zcash_client_sqlite/src/lib.rs 50.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1636      +/-   ##
==========================================
- Coverage   56.39%   56.37%   -0.02%     
==========================================
  Files         149      149              
  Lines       19466    19476      +10     
==========================================
+ Hits        10977    10980       +3     
- Misses       8489     8496       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuttycom nuttycom force-pushed the wallet/imported_spending_key_metadata branch from 7fa87b5 to f1724c4 Compare December 6, 2024 01:24
@nuttycom nuttycom enabled auto-merge December 6, 2024 01:27
@nuttycom nuttycom force-pushed the wallet/imported_spending_key_metadata branch from f1724c4 to cc2dfbf Compare December 6, 2024 02:35
@nuttycom
Copy link
Contributor Author

nuttycom commented Dec 6, 2024

force-pushed to address comments from review.

@nuttycom nuttycom requested a review from str4d December 6, 2024 02:50
str4d
str4d approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK cc2dfbf

@nuttycom nuttycom added this pull request to the merge queue Dec 6, 2024
@nuttycom nuttycom removed this pull request from the merge queue due to a manual request Dec 6, 2024
@nuttycom nuttycom added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit f6040a1 Dec 6, 2024
28 checks passed
@nuttycom nuttycom deleted the wallet/imported_spending_key_metadata branch December 6, 2024 03:30
daira
daira reviewed Dec 7, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira left review comments

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuttycom @daira @str4d